Fix requestFrom() return type for 16-bit lengths #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@facchinm @cmaglie I think we should go with this, but it impacts all the cores and |
|
It looks reasonable indeed; no code should break due to automatic promotion but we need to change the non virtual implementation in mbed and megaAVR core if we apply it to API repo. |
aentinger
force-pushed
the
wire-requestfrom-return
branch
from
3f09252 to
7f8867b
Compare
|
Depends on arduino/ArduinoCore-API#132. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest changes to the SAMD core create a 256-byte templated ring buffer for received data in the
Wireclass. However, therequestFrommethods only support auint8_treturn type, which means they report0for the number of bytes received after a 256-byte request (I found this out the hard way). This fix changesuint8_ttosize_tto match thequantityargument data type and thebyteReadvariable data type, which is the one actually used to provide the return value.